-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Np 124 - getting rid of mui autocomplete #677
Conversation
Vercel Preview URL 🚀 : https://planner-8pxlstvrp-utdnebula.vercel.app |
Vercel Preview URL 🚀 : https://planner-e2hvlopdb-utdnebula.vercel.app |
Vercel Preview URL 🚀 : https://planner-2cj2g8dz8-utdnebula.vercel.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't sure if this was ready to be reviewed, but could you style it as seen in the Figma:
https://www.figma.com/file/nW5wBYFetauCmIdt9e5BtA/Nebula-Planner?type=design&node-id=607-4948&mode=dev?
Also, the integration tests rely on the MUI component to select a major during plan creation. We should fix that to work with the new select if possible!
Lmk if you need help figuring out integration test stuff. We run them locally via |
Vercel Preview URL 🚀 : https://planner-gihjkl66r-utdnebula.vercel.app |
Vercel Preview URL 🚀 : https://planner-rolx2f65y-utdnebula.vercel.app |
Vercel Preview URL 🚀 : https://planner-ddmvj9exk-utdnebula.vercel.app |
Vercel Preview URL 🚀 : https://planner-k0ekqueei-utdnebula.vercel.app |
Vercel Preview URL 🚀 : https://planner-lgr3hbt4x-utdnebula.vercel.app |
Stale and #728 resuming progress. |
Used react-select which does not actively support options that are just simple strings so I had to convert the list of majors into
{ label: element, value: element }
format