Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Np 124 - getting rid of mui autocomplete #677

Closed
wants to merge 15 commits into from
Closed

Conversation

NoWhere-2-Go
Copy link
Contributor

Used react-select which does not actively support options that are just simple strings so I had to convert the list of majors into { label: element, value: element } format

@NoWhere-2-Go NoWhere-2-Go requested review from a team and akevinge as code owners September 21, 2023 23:02
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

Copy link
Member

@akevinge akevinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure if this was ready to be reviewed, but could you style it as seen in the Figma:
https://www.figma.com/file/nW5wBYFetauCmIdt9e5BtA/Nebula-Planner?type=design&node-id=607-4948&mode=dev?

Also, the integration tests rely on the MUI component to select a major during plan creation. We should fix that to work with the new select if possible!

@akevinge
Copy link
Member

Lmk if you need help figuring out integration test stuff. We run them locally via npm run cypress:open, the validator also needs to be running before you run the test.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

@kamui-fin
Copy link
Contributor

On the preview, it doesn't look like the major autocomplete is working properly. I checked the state for options and they're all undefined. If it helps:
image

So the [{ label: ... }] also becomes a list of undefined objects. Integration tests need tweaking so it picks up on this.

@kamui-fin
Copy link
Contributor

Stale and #728 resuming progress.

@kamui-fin kamui-fin closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants