Merge pull request #694 from UTDNebula/NP-92

Fix(NP-92) Changing file to read binary
UTDNebula · Oct 2, 2023 · 5c2c47e · 5c2c47e
2 parents 746cb0b + 42aedc9
commit 5c2c47e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/validator/scripts/diff.py b/validator/scripts/diff.py
@@ -82,10 +82,9 @@ def createTicket(issueType: str, jira_connection: JIRA, URI: str, coursesImpacte
         customfield_10016=1,
         labels=["Engineering"],
     )
-    f = open("description.txt", "r")
     if os.path.getsize("description.txt"):
-        jira_connection.add_attachment(issue=ticket, attachment=f)
-    f.close()
+        with open("description.txt", "rb") as descriptionFile:
+            jira_connection.add_attachment(issue=ticket, attachment=descriptionFile)
     os.remove("description.txt")
 
 #Establishes JIRA connection and ierates through each major for versioning issues