Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUP-71 Backend Changes #252

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

JUP-71 Backend Changes #252

wants to merge 6 commits into from

Conversation

BK2004
Copy link
Contributor

@BK2004 BK2004 commented Oct 23, 2024

  • Added officers table for listed officers
  • Removed title field from userMetadataToClubs and all references to it

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 9:10pm

RubenOlano
RubenOlano reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions here let me know if I'm just being dumb

src/server/db/schema/officers.ts Outdated Show resolved Hide resolved
src/server/db/schema/officers.ts Outdated Show resolved Hide resolved
RubenOlano
RubenOlano requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final nitpick

src/server/db/schema/officers.ts Outdated Show resolved Hide resolved
RubenOlano
RubenOlano approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenOlano RubenOlano RubenOlano approved these changes

@nl32 nl32 Awaiting requested review from nl32 nl32 is a code owner

@KennethImphean KennethImphean Awaiting requested review from KennethImphean KennethImphean is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BK2004 @RubenOlano