Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUP-57 Sidebar #230

Merged
merged 7 commits into from
Aug 12, 2024
Merged

JUP-57 Sidebar #230

merged 7 commits into from
Aug 12, 2024

Conversation

nl32
Copy link
Contributor

@nl32 nl32 commented Jul 22, 2024

Refactor the full sidebar and mobile sidebar to use the same component for the actual navigation content.

also moves the admin menu to the sidebar, along with the club manage menu, if a user should have access to these pages.

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 4:39am

Copy link
Contributor

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor nitpick would be that the sidebar does not show up on mobile but I'm pretty sure that's my fault and not yours

@nl32 nl32 merged commit fd0d09e into develop Aug 12, 2024
3 checks passed
@nl32 nl32 deleted the JUP-57-sidebar branch August 12, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants