Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing margins in Organization Grid and README update #202

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

KennethImphean
Copy link
Contributor

@KennethImphean KennethImphean commented Feb 22, 2024

Want to make margins smaller in directory grid when the website is fullscreen, but resolution was an issue. It now displays 3 organizations per row on a 1600 width screen. I would like to know how this build looks on other people's machines, to further refine the margins. Also there was a slight update to README for newer members to help them set up their enumerated values in Supabase.

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupiter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 3:01pm

@Jake3231
Copy link
Contributor

@KennethImphean I'd suggest updating the title to something more specific to this change, such as "show 3 orgs per row in directory grid" or "Reduce org grid margins"

Also, is it expected to include the README changes in this PR?

@KennethImphean
Copy link
Contributor Author

@Jake3231 I'll change the pull request later to me more specific, this draft was only to show Ruben how the changes would look on his machine because my resolution is bigger on my laptop. I just wanted to make sure that the org grid looked similar on different resolutions. Also, yes the README changes are for newer people to set up ENUMs for the tables in Supabase.

@KennethImphean KennethImphean changed the title Changes to OrgDirectoryGrid Reducing margins in Organization Grid and README update Feb 28, 2024
@KennethImphean KennethImphean marked this pull request as ready for review February 29, 2024 01:45
@RubenOlano
Copy link
Contributor

Margins are still kinda weird on my end. I think its mostly grid that's causing this. Best thing I can think of is using flex with justify-between or one of those variants so that the cards take up all the available space that they can

@RubenOlano RubenOlano marked this pull request as draft March 22, 2024 22:18
@Jake3231
Copy link
Contributor

How is this looking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants