Gerhard/uma 2479 ensure osnap form input types working correctly #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gsteenkamp89
changed the base branch from
master
to
gerhard/uma-2431-figure-out-how-to-get-safe-transactions-into-snapshot-osnap
gsteenkamp89
changed the base branch from
gerhard/uma-2431-figure-out-how-to-get-safe-transactions-into-snapshot-osnap
to
master
gsteenkamp89
changed the base branch from
master
to
gerhard/uma-2431-figure-out-how-to-get-safe-transactions-into-snapshot-osnap
gsteenkamp89
changed the base branch from
gerhard/uma-2431-figure-out-how-to-get-safe-transactions-into-snapshot-osnap
to
uma-add-safe-transaction-file-import-to-osnap-plugin
Co-authored-by: ChaituVR <[email protected]>
…nto gerhard/uma-2479-ensure-osnap-form-input-types-working-correctly
…e builder (#4649) * feat: allow safe json upload into osnap tx builder Signed-off-by: david <[email protected]> * parse batchfile & populate input fields with values * show value & to fields * improve input * improve file input error handling and styling * refactor * refactor * minor bug fix * allow quick fix for short bytes32 * align icon better * make file input own component * import file once and initialize multiple safeImport transactions * check if safe address & chainId match * small fixes * clean up comments * better border sie for file input * clear input element value to allow recurring upload * fix quick fix * handle multiple files * better error message * emit from watcher * fix: use upstream state only * clean up * do byteslike check last * fixes * add default label * fix: remove component level tx state * Merge branch 'master' into uma-add-safe-transaction-file-import-to-osnap-plugin * validate address input on blur * clean up input css * improve bytes32 error message * replace readOnly with hidden, casing change --------- Signed-off-by: david <[email protected]> Co-authored-by: david <[email protected]> Co-authored-by: Chaitanya <[email protected]>
|
@daywiss I've added better checks for Integers as well. We now do range checks for all integer types. I noticed I was able to insert values for
|
gsteenkamp89
changed the base branch from
uma-add-safe-transaction-file-import-to-osnap-plugin
to
master
gsteenkamp89
changed the base branch from
master
to
uma-add-safe-transaction-file-import-to-osnap-plugin
gsteenkamp89
force-pushed
the
gerhard/uma-2479-ensure-osnap-form-input-types-working-correctly
branch
from
2dbae98
to
53f5681
Compare
gsteenkamp89
changed the base branch from
uma-add-safe-transaction-file-import-to-osnap-plugin
to
master
…ypes-working-correctly
gsteenkamp89
changed the base branch from
master
to
uma-add-safe-transaction-file-import-to-osnap-plugin
|
closing in favor of #161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
Currently our transaction builder is not parsing or validating array or tuple param types AT ALL!
This PR seeks to properly parse array inputs and validate members of those arrays.
both
arrayandtupleinputs require an array (square brackets) in the input field.but
arrayparam members are always the same type so if the type isuint256[]then we validate each member of teh array as auint156but tuples are more complex since they generally represent struct values, so a tuple's type can be
[uint256,address,bool]To test
requestPricerequestSettings, the tuple type is[bool,bool,bool,Int,Int]Or find any ABI with function parameters of type Array or Tuple and test the input.