Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 Changes - including _b flag for pokemon bread forms #9

Merged
merged 8 commits into from
Sep 13, 2024

Conversation

TurtIeSocks
Copy link
Owner

@TurtIeSocks TurtIeSocks commented Sep 11, 2024

Since adding the _b flag was going to be a breaking change, if implemented correctly, I took the time to also update some of the other function signatures that were either missing some flag support or were in the "wrong" order. The following methods have had their function signature changed in some way:

  • gym: added support for _p or power up flag (non-breaking)
  • pokemon: changed order of arguments to match standard, plus added _b bread flag
    • old: pokemon_id, form, evo, gender, costume, alignment, shiny
    • new: pokemon_id, evo, form, costume, gender, alignment, bread, shiny
  • pokestop: changed order of arguments to match standard.
    • old: lure_id, power, display, invasionActive, questActive, ar
    • new: lure_id, display (boolean | number | string), questActive (boolean | number | string), ar, power
  • weather: added support for _l (severity level) flag, changed argument order to reflect standard
    • old: weather_id, time_of_day
    • new: weather_id, severity_level, time_of_day

Pending the merge of UIcons/UIcons#37

BREAKING CHANGE: order of pokemon arguments has changed to align better with uicons standard
BREAKING CHANGE: changes order of pokestop args to better align with uicons standard
BREAKING CHANGE: changes order of args for weather method
@TurtIeSocks TurtIeSocks merged commit d27f76d into main Sep 13, 2024
1 check passed
@TurtIeSocks TurtIeSocks deleted the 2.0-fixes branch September 13, 2024 02:29
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant