2.0 Changes - including _b flag for pokemon bread forms
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: order of pokemon arguments has changed to align better with uicons standard
BREAKING CHANGE: changes order of pokestop args to better align with uicons standard
BREAKING CHANGE: changes order of args for weather method
TurtIeSocks
force-pushed
the
2.0-fixes
branch
from
b7ae1b6
to
d7e9841
Compare
|
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since adding the
_bflag was going to be a breaking change, if implemented correctly, I took the time to also update some of the other function signatures that were either missing some flag support or were in the "wrong" order. The following methods have had their function signature changed in some way:gym: added support for_por power up flag (non-breaking)pokemon: changed order of arguments to match standard, plus added_bbread flagpokemon_id, form, evo, gender, costume, alignment, shinypokemon_id, evo, form, costume, gender, alignment, bread, shinypokestop: changed order of arguments to match standard.lure_id, power, display, invasionActive, questActive, arlure_id, display (boolean | number | string), questActive (boolean | number | string), ar, powerweather: added support for_l(severity level) flag, changed argument order to reflect standardweather_id, time_of_dayweather_id, severity_level, time_of_dayPending the merge of UIcons/UIcons#37