feat: API Option to Center Clusters on Points #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API option
center_clustersthat tells koji to make an attempt to recenter a cluster based on its points. This uses a variation of the Smallest Enclosing Circle problem to solve the new centers.Sometimes it can fail to resolve a new center that still covers all of the points but it will automatically fallback to the original cluster if that happens. This generally happens on clusters that have a large number of points, clusters that don't particularly need re-centering anyway.
Despite the large number of operations happening, the code is quite speedy but it is opt in in case you don't want to bother.