Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/sortCommentsByUpvote #88

Merged
merged 1 commit into from
Aug 25, 2024
Merged

feature/sortCommentsByUpvote #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/hooks/useGetComments.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,17 @@ const useGetComments = (url: string) => {
}
});

// Sort comments and replies by creation time
comments = comments.sort(
(a, b) => new Date(a.Created.Time) - new Date(b.Created.Time)
);
// Sort comments and replies by upvote, then creation time
comments = comments.sort((a, b) => {
// First sort by Upvote
const upvoteDifference = (b.Upvote || 0) - (a.Upvote || 0);
// If Upvote values are the same, sort by Created.Time
if (upvoteDifference !== 0) {
return upvoteDifference;
}
// Secondary sort by Created.Time
return new Date(b.Created.Time) - new Date(a.Created.Time);
});
replies = replies.sort(
(a, b) => new Date(a.Created.Time) - new Date(b.Created.Time)
);
Expand Down