Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Bijectors to 0.14.0 #2384

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Bump Bijectors to 0.14.0 #2384

merged 2 commits into from
Nov 7, 2024

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Oct 29, 2024

Following on from TuringLang/Bijectors.jl#337.

I dropped support for 0.13 because 0.13 requires Tapir not Mooncake anyway.

Don't merge yet; the rest of TuringLang needs to be Bijectors-0.14-compatible, and it isn't.

Closes #2385

@penelopeysm penelopeysm force-pushed the py/bump-bijectors branch 2 times, most recently from def68db to cf6b195 Compare October 29, 2024 17:38
@penelopeysm penelopeysm marked this pull request as draft October 30, 2024 11:23
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (397d1a7) to head (accf79a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2384      +/-   ##
==========================================
+ Coverage   76.81%   86.39%   +9.58%     
==========================================
  Files          22       22              
  Lines        1570     1573       +3     
==========================================
+ Hits         1206     1359     +153     
+ Misses        364      214     -150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yebai yebai marked this pull request as ready for review November 7, 2024 14:29
@yebai yebai merged commit 470f447 into master Nov 7, 2024
69 checks passed
@yebai yebai deleted the py/bump-bijectors branch November 7, 2024 14:29
@yebai
Copy link
Member

yebai commented Nov 7, 2024

Thanks @penelopeysm!

@penelopeysm
Copy link
Member Author

I must confess I'm surprised that tests passed 😲

Thanks for coming back to this @yebai

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11722796016

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.685%

Totals Coverage Status
Change from base Build 11594848843: 0.0%
Covered Lines: 1233
Relevant Lines: 1567

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants