Tapir -> Mooncake #338
Tapir -> Mooncake #338
Conversation
penelopeysm
force-pushed
the
py/inline-import-and-mooncake
branch
from
d13a202
to
0a8d1cd
Compare
|
Re the Mooncake failure -- I knew about this possibility previously, but this is the first time I've seen it in the wild. Sadly, I'm not 100% sure where to start on fixing this. See compintell/Mooncake.jl#319 for more context. |
|
I'll mark the Mooncake test as broken and then we can go from there. Thanks both! |
| if (AD == "All" || AD == "Mooncake") && VERSION >= v"1.10" | ||
| try | ||
| Mooncake.build_rrule(f, x) | ||
| catch exc | ||
| # TODO(penelopeysm): | ||
| # @test_throws AssertionError (expr...) doesn't work, unclear why | ||
| @test exc isa AssertionError | ||
| end |
There was a problem hiding this comment.
I don't know why @test_throws doesn't work here, it's completely inexplicable. (When I use @test_throws, it doesn't throw an exception, so @test_throws fails)
However, I also didn't want to spend another 2 hours debugging this, so I'm just reverting to catching the expression and testing it.
There was a problem hiding this comment.
BTW, we could simply exclude Mooncake from testing entirely, but I prefer having this as it will let us know when the bug above is fixed.
|
Remaining failing tests are due to Enzyme, I'm going to go ahead and merge first. |
* Disable fail-fast on CI * Inline expanded frule and rrule in BijectorsEnzymeExt * Bump patch version * Remove BijectorsEnzymeExt on 1.11.1+ * Tapir -> Mooncake (#338) * Tapir -> Mooncake * Bump minor version * Mark Mooncake test as broken * Remove BijectorsEnzymeExt on 1.11.1+ * Increase tolerance on `ordered` test
See #337 (comment) for context.