Require AbstractMCMC 5 #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torfjelde
reviewed
Oct 4, 2024
| @@ -1,31 +1,8 @@ | |||
| [deps] | |||
| AbstractMCMC = "80f14c24-f653-4e6a-9b94-39d6b0f70001" | |||
There was a problem hiding this comment.
That's ok. These packages are already on the deps list for the main package.
There was a problem hiding this comment.
The test was failing in the first commit since this Project.toml file restricted AbstractMCMC to < 5. However, I noticed that AbstractMCMC is neither loaded nor accessed in the files in this folder at all. Which made me curious, so I searched for all packages in the Project.toml file and removed all of them that do not show up anywhere in research/
yebai
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since AdvancedHMC uses the keyword argument
initial_paramsand AbstractMCMC 4 usedinit_params, I think we should require AbstractMCMC 5 which also usesinitial_params.