Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lineOffset spherical geometry errors (fix #2278) #2281

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Simage
Copy link

@Simage Simage commented Apr 9, 2022

Project geometries to Azimuthal Equidistant projection prior to transformation and then back to WGS84.

There is an earlier similar PR however it has a unique implementation whereas this implementation duplicates the projection code from the buffer implementation. Ideally, this projection code would eventually be refactored into a utility and maintained in a single location

Bjorn Harpe added 2 commits April 8, 2022 23:23
Project geometries to Azimuthal Equidistant projection prior
to transformation and then back to WGS84
Use correct geometry types
correct import
Use coordinates rather than the geometry object
@Simage Simage changed the title Fix lineOffset spherical geometry errors Fix lineOffset spherical geometry errors (#2278) Apr 12, 2022
@Simage Simage changed the title Fix lineOffset spherical geometry errors (#2278) Fix lineOffset spherical geometry errors (fix #2278) Apr 12, 2022
@JamesLMilner
Copy link
Collaborator

@rowanwins perhaps the best person to weigh in on this? It seems sensible to me but perhaps there's side effects I'm not seeing

@rowanwins
Copy link
Member

rowanwins commented Oct 6, 2022

This PR might help in some circumstances but I don't think it will resolve some of the bigger underlying issues unfortunantly (eg #1439).
PS I did do a quick check and alas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants