Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation days support for beta and stable levels #316

Conversation

tcdsv
Copy link
Collaborator

@tcdsv tcdsv commented Jul 10, 2023

closes #283

  • the changelog and breaking command now include deprecation-days flags for both beta and stable versions.
  • updated ChangelogFlags with new deprecation days flags
  • removed hardcoded deprecation days values
  • removed unused DeprecationDays field from ChangelogFlags and diff.Config

@tcdsv tcdsv changed the title fix: flag deprecation days ignored by check breaking add deprecation days support for beta and stable levels Jul 10, 2023
Copy link
Collaborator

@reuvenharrison reuvenharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Please update API-DEPRECATION.md

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Merging #316 (a1f07ca) into main (8deecbf) will not change coverage.
The diff coverage is 81.81%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files         177      177           
  Lines        8918     8918           
=======================================
  Hits         6942     6942           
  Misses       1701     1701           
  Partials      275      275           
Flag Coverage Δ
unittests 77.84% <81.81%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
checker/deprecation.go 75.00% <ø> (ø)
diff/config.go 100.00% <ø> (ø)
internal/changelog_flags.go 100.00% <ø> (ø)
checker/default_checks.go 90.56% <66.66%> (ø)
internal/breaking_changes.go 100.00% <100.00%> (ø)
internal/changelog.go 70.40% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@reuvenharrison reuvenharrison merged commit 1d7d722 into Tufin:main Jul 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecation-days is ignored
3 participants