Allow --host to be set through helm
#334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amouat
approved these changes
Dec 19, 2022
|
Can you rebase? I commented out this test in the latest code. |
|
Great, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enable optional IPv6 support by allowing trow to be bound to
::through the helm chartRelated to #333.
I don't wanted to create a "core change" for that by changing the default value for the CLI arg, as this might also break windows support (depends on how windows handles
::when binding sockets), or possibly even non-standard Linux configurations.I tested it successfully in my test cluster and it works.