Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/fw_dell_optiplex.md: update coreboot revision and coreboot-sdk revision #9

Closed
wants to merge 2 commits into from

Conversation

miczyg1
Copy link

@miczyg1 miczyg1 commented Oct 19, 2023

No description provided.

@pietrushnic
Copy link
Member

It is great you were able to achieve some improvements for Dell OptiPlex. What I really miss is the impact on our products. This improvement will be lost in this repo. Why don't we push that to the official Dasharo Dell OptiPlex documentation and not link there, but instead use TrechnBoot documentation?

@BeataZdunczyk @macpijan cc

@krystian-hebel
Copy link
Contributor

Why don't we push that to the official Dasharo Dell OptiPlex documentation

Because this is not Dasharo, this is upstream coreboot.

Copy link
Contributor

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typo in the commit message. Some summary as to why this bump was needed would also be nice.

@@ -32,7 +32,7 @@ correctly.
docker run --rm -it \
-v $PWD:/home/coreboot/coreboot \
-w /home/coreboot/coreboot \
coreboot/coreboot-sdk:0ad5fbd48d
coreboot/coreboot-sdk:2023-06-04_44f676afc9
```

- Build coreboot firmware:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds without errors, but I don't think Built dell/e6400 (Latitude E6400) is the expected result...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay... New target landed upstream...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pietrushnic
Copy link
Member

pietrushnic commented Oct 19, 2023

Because this is not Dasharo, this is upstream coreboot.

@krystian-hebel upstream coreboot is the basis for almost all Dasharo code. We should treat the TB AEM project as an opportunity to bring products to the 3mdeb shop, but I understand your point - this is not your job, not part of the scope. So I will assume this should be part of the backlog tasks for Dasharo, compatible with Optiplex release @macpijan @BeataZdunczyk cc

@krystian-hebel, one more thing to be clear in future discussion. Ideally, Dasharo releases would use everything upstream without changes, and the only value the Dasharo Team would add is distribution, compliance (aka certification), and support as the base.

@SergiiDmytruk SergiiDmytruk changed the title Documentation/fw_dell_optiplex.md: update coreboto revision and coreboot-sdk revision Documentation/fw_dell_optiplex.md: update coreboot revision and coreboot-sdk revision Aug 20, 2024
@SergiiDmytruk
Copy link
Member

Cleanup: @krystian-hebel, maybe you want to finish the review.

@krystian-hebel
Copy link
Contributor

It was moved to https://docs.dasharo.com/variants/dell_optiplex/building-manual/, and old instructions for building and config file will be removed from here as part of TrenchBoot/trenchboot-issues#29.

@krystian-hebel krystian-hebel deleted the dell_optiplex_fw_update branch August 26, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants