gram

resources/posts/2023/2023-07-10-two-kinds-of-legacy-code-upgrade.md

@@ -10,14 +10,14 @@ perex: |
 
 <blockquote class="blockquote text-center">
 "Do you plan to sell the project next year<br>
-or are you going to work on it for the next 5 years?"
+or will you work on it for the next 5 years?"
 </blockquote>
 
 
 
-Put in another words:
+Put in other words:
 
-* do you want to meet your KPI in as short time as possible to "make your boss happy",
+* do you want to meet your KPI in an as short time as possible to "make your boss happy",
 * or do you want to make the codebase work for you and save your money in the future?
 
 
@@ -29,17 +29,17 @@ Let's say the goal is to upgrade from PHP 7.0 to PHP 7.4.
 ## 1. The Superficial Upgrade
 
 
-This kind of upgrade is like a house renovation not for your own living, but for selling it to someone else. You want to **increase the perceived value of the house, but you don't really care about the quality of the renovation**.
+This kind of upgrade is like a house renovation, not for your own living but for selling it to someone else. You want to **increase the perceived value of the house, but you need to care about the quality of the renovation**.
 
 <img src="https://www.boredpanda.com/blog/wp-content/uploads/2020/10/house-renovations-that-look-worse-than-before-5f8999bd31606__700.jpg" class="img-thumbnail" style="width: 20em">
 
-The same applies to code. You want to **increase the perceived value of the codebase, but you don't really care about the quality of the code**.
+The same applies to code. You want to **increase the perceived value of the codebase, but you need to care about the quality of the code**.
 
 <br>
 
 When we say in the news that our code base uses PHP 7.4, what does it usually mean? 2 things:
 
-1. The `composer.json` uses this version as minimum:
+1. The `composer.json` uses this version as a minimum:
 
 ```json
 {
@@ -57,11 +57,11 @@ When we say in the news that our code base uses PHP 7.4, what does it usually me
 FROM php:7.4-cli-alpine
 ```
 
-This may seems like it allows you to say in a job advertisement that your project "use PHP 7.4".
+This may seem like it allows you to say in a job advertisement that your project "use PHP 7.4".
 
 <br>
 
-But **how does the code really look like?**
+But **what does the code really look like?**
 
 ```php
 class ProjectManager
@@ -82,7 +82,7 @@ class ProjectManager
 }
 ```
 
-You're right, we define the PHP version number in the `composer.json` and `Dockerfile`
+You're right; we define the PHP version number in the `composer.json` and `Dockerfile.`
 
 <br>
 
@@ -91,32 +91,32 @@ But we **don't really use any of PHP 7.4 features**:
 * param type declarations (since PHP 7.0+)
 * return type declarations (since PHP 7.0+)
 * void type declaration (since PHP 7.1+)
-* property type declaration (since PHP 7.4+)
+* Property type declaration (since PHP 7.4+)
 
 <br>
 
-Still, you can tell your boss who doesn't understand the complexity of upgrade that you use the PHP 7.4 already. Collect the bonus for handling the upgrade and make them happy. At least for a year or two, till the technical debt will hit you back.
+Still, you can tell your boss, who doesn't understand the complexity of the upgrade, that you use PHP 7.4 already. Collect the bonus for handling the upgrade and make them happy. At least for a year or two, till the technical debt hits you back.
 
 <br>
 
 ## 2. The Long-Term Value Upgrade
 
-The other way is like reconstructing a **house for you and your family to live in at least for next 20 years**.
+The other way is like reconstructing a **house for you and your family to live in for at least the next 20 years**.
 
-You care about the usability of house, new windows that will make the noise and temperature changes under control, noise isolation, cheap energy use during winter, warm water for shower and enough storage space.
+You care about the usability of the house. These new windows will make the noise and temperature changes under control, noise isolation, cheap energy use during winter, warm water for the shower, and enough storage space.
 
 <img src="https://user-images.githubusercontent.com/924196/252729834-a174bb1a-e5f9-403f-be38-250a00608ff2.png" class="img-thumbnail" style="width: 20em">
 
-It's not about making it look nice and shiny, but about **making it work for you in the long- term**.
+It's not about making it look nice and shiny but about **making it work for you in the long- term**.
 
 
-It takes more time and it's more expensive, because you deserve to have a decent home. At the start it might be frustrating, as you have to take down old paint and furniture, check the sewage and electricity wires. After 2 months of reconstruction, the house look much worse than you've started.
+It takes more time, and it's more expensive because you deserve to have a decent home. It might be frustrating at the start, as you must take down old paint and furniture and check the sewage and electricity wires. After 2 months of reconstruction, the house looks much worse than you started.
 
-But in the long term, you know for sure the foundations are done correctly, you don't have to worry about any "surprises" like turning on washing machine and induction cooker table.
+But in the long term, you know for sure the foundations are done correctly, and you don't have to worry about any "surprises" like turning on the washing machine and induction cooker table.
 
 <br>
 
-The same applied for the legacy codebase upgrade: you user the latest PHP features right away:
+The same applied to the legacy codebase upgrade: you use the latest PHP features right away:
 
 ```diff
 -class ProjectManager
@@ -141,13 +141,13 @@ The same applied for the legacy codebase upgrade: you user the latest PHP featur
  }
 ```
 
-This code is in much better shape, then the one above, and it's using only PHP 7.1
+This code is in much better shape than the one above, and it uses only PHP 7.1
 
-It allows hiring new people faster, adding new features with less regression bugs and it's easier to maintain.
+It allows hiring new people faster, adding new features with fewer regression bugs, and it's easier to maintain.
 
 <br>
 
-In [Rector team](https://getrector.com/hire-team) we **always go for the the long-term value**, as we care about clients' success and exponential groth, not about short-term profit that will put the company down.
+In [Rector team](https://getrector.com/hire-team), we **always go for the long-term value**, as we care about clients' success and exponential growth, not about short-term profit that will put the company down.
 
 
 <br>