Add min and max validation in TTY::Prompt::MultiList
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a `MultiList#validate_min_max` method to ensure `min` is less than or equal to `max` - Call `validate_min_max` during initialization and when setting `min` and `max` values - Update `MultiList#keyenter` to check both `min` and `max` constraints are satisfied on selection - Update `output_helper` method in `multi_select_spec.rb` to support both `min` and `max` help text
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
MultiList#validate_min_maxmethod to ensureminis less than or equal tomaxvalidate_min_maxduring initialization and when settingminandmaxvaluesMultiList#keyenterto check bothminandmaxconstraints are satisfied on selectionoutput_helpermethod inmulti_select_spec.rbto support bothminandmaxhelp textWhy are we doing this?
This PR introduces validation logic to ensure that the
minvalue is less than or equal to themaxvalue in theTTY::Prompt::MultiListclass. This would close piotrmurach#172 and piotrmurach#173.Benefits
This change prevents invalid configurations and ensures that the selection constraints are properly enforced.
Drawbacks
Possible drawbacks applying this change.
Requirements
masterbranch?