Fix1 #569
Closed
Fix1 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a couple of breaking tests... looking |
|
@sug44 removing exact path has caused bugs |
|
the tests were breaking on the parent commit as well, so i didnt try to fix any of them |
|
yeah, but the removal has caused somethings there is also the usage of realpath that is causing breaking |
|
also... i realized... i cannot have this change i am going to have to think of something different. this change breaks one of the core concepts of harpoon. i can have 2 repos, both with the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sug44 here you go