Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Navbar. #13

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Updated Navbar. #13

wants to merge 14 commits into from

Conversation

wolfieboy09
Copy link

Added the new logo. You may have to add width="" and hight="" to it.
I'm not that familiar with HTML, so the devs have to add that.

Copy link
Collaborator

@rgantzos rgantzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the images, you set the src, but the path for the image doesn't include the /images/, meaning the logo won't load.

README.md Outdated Show resolved Hide resolved
@rgantzos rgantzos added bug Something isn't working and removed Being reviewed labels Nov 28, 2022
@wolfieboy09
Copy link
Author

Let me fix the image

@wolfieboy09
Copy link
Author

@rgantzos I fixed the src in all the HTML files

@wolfieboy09
Copy link
Author

wolfieboy09 commented Nov 29, 2022

How do I approve the change?

@wolfieboy09
Copy link
Author

I fixed the src tag, so can we remove the bug tag?

@rgantzos
Copy link
Collaborator

rgantzos commented Dec 1, 2022

href is spelled as herf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants