Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timing repair: allow negative HOLD_SLACK_MARGIN in floorplan #2540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions flow/scripts/util.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@ proc fast_route {} {
}
}

# -hold_margin is only set when hold_margin is set, default 1
proc repair_timing_helper { {hold_margin 1} } {
set additional_args "-verbose"
append_env_var additional_args SETUP_SLACK_MARGIN -setup_margin 1
if {$hold_margin} {
if {$hold_margin || $::env(HOLD_SLACK_MARGIN) < 0} {
append_env_var additional_args HOLD_SLACK_MARGIN -hold_margin 1
}
append_env_var additional_args TNS_END_PERCENT -repair_tns 1
Expand Down
13 changes: 13 additions & 0 deletions flow/scripts/variables.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -335,10 +335,22 @@ HOLD_SLACK_MARGIN:
Specifies a time margin for the slack when fixing hold violations.
This option allows you to overfix or underfix(negative value, terminate
retiming before 0 or positive slack).

Use min of HOLD_SLACK_MARGIN and 0(default hold slack margin) in floorplan.

This avoids overrepair in floorplan for hold by default, but allows skipping
hold repair using a negative HOLD_SLACK_MARGIN.

Exiting timing repair early is useful in exploration where

the .sdc has a fixed clock period at designs target clock period and where
HOLD/SETUP_SLACK_MARGIN is used to avoid overrepair(extremelly long running times)
when exploring different parameter settings.
stages:
- cts
- floorplan
- grt
default: 0
SETUP_SLACK_MARGIN:
description: >
Specifies a time margin for the slack when fixing setup violations.
Expand All @@ -348,6 +360,7 @@ SETUP_SLACK_MARGIN:
- cts
- floorplan
- grt
default: 0
SKIP_GATE_CLONING:
description: >
Do not use gate cloning transform to fix timing violations (default: use gate cloning).
Expand Down
Loading