[Docs] CI for variables.yaml + CI for docs update #2457
Conversation
Signed-off-by: Jack Luar <[email protected]>
| - name: Run YAML Lint | ||
| run: | | ||
| pip install yamllint==1.35.1 | ||
| yamllint flow/scripts/variables.yaml |
There was a problem hiding this comment.
Can we pick a yaml linting tool that, like black, for python, you can just run to fix the formatting?
I'm not picky on yaml linting rules, I just want automatic update, like black does for python.
| else | ||
| echo "has_update=false" >> "$GITHUB_OUTPUT" | ||
| fi | ||
| git add . |
There was a problem hiding this comment.
this can add anything in the source folder, why add anything beyond FlowVariables.md?
There was a problem hiding this comment.
In fact, if anything under source control is change, except FlowVariables.md, this action should terminate, no?
…ction Signed-off-by: Jack Luar <[email protected]>
| name: ORFS variables.yaml tester and linter | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
shouldn't this be pull-request, not on push(to a branch) test linting?
otherwise I don't think it will tests pull requests as only those with write access to the ORFS can create branches
The rest of the PR I think is designed to run after updates to master
Tracked in #2452
Fixes #2444