Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes and cleanup #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

FarzeenKist
Copy link

@FarzeenKist FarzeenKist commented Oct 21, 2022

Fixes and Improvements

  1. Cleanup of redundant variables that were not used/already provided by another variable (the creator address in the Global object/class)
  2. I've noticed that users could like and dislikes as many times as they wished. I've gone ahead and fixed that by having a local variable like keep track of whether the sender has liked it. I didn't add a check in the like and dislike subroutine/function to check if the user has opted in since it's already required by the blockchain to be able to use local storage, however, feel to add one if you see the need for it.
  3. Implemented the function to run when a user opts in.
  4. Added additional comments to clarify of what the checks are doing
  5. Removed redundant checks in your functions around the group transactions as it was unnecessary, instead I'd suggest you make the transactions to be individual on the frontend instead of being grouped(except the buy function)

@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
booksville ✅ Ready (Inspect) Visit Preview Oct 21, 2022 at 5:55PM (UTC)

Repository owner deleted a comment from netlify bot Oct 26, 2022
@LMDH01
Copy link

LMDH01 commented Feb 21, 2024

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants