Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to DumpUtility #67

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Updates to DumpUtility #67

merged 3 commits into from
Oct 3, 2023

Conversation

cljohnso
Copy link
Contributor

This commit stream updates DumpUtility to:

  • correct recognition java.nio.ByteBufferAsIntBufferB (typo)
  • make adjustments to support Java 17+
  • add usage comments
  • add tests
  • minor updates to output for LongBuffer and IntBuffer

The commit stream also adds the ModuleSupport class providing support for checking if, under Java 9+ the UNNAMED module has reflection access to a given class/instance.

@cljohnso
Copy link
Contributor Author

Seems I have a toolchain issue with CI machines ... will need to coordinate with @akomakom

@github-actions
Copy link

github-actions bot commented Sep 20, 2023 •
edited
Loading

Tests Results

   605 files  +     35     605 suites  +35   19m 27s ⏱️ + 10m 7s
   950 tests +   652     913 ✔️ +   619    37 💤 +  33  0 ❌ ±0 
9 380 runs  +4 910  8 820 ✔️ +4 665  560 💤 +245  0 ❌ ±0 

Results for commit 6508ea9. ± Comparison against base commit ca95390.

♻️ This comment has been updated with latest results.

@cljohnso
Copy link
Contributor Author

Seems I have a toolchain issue with CI machines ... will need to coordinate with @akomakom

Ok ... Azure CI appears to lack support for toolchains.xml -- which the current approach to testing DumpUtility needs. I need to figure out a different approach.

@cljohnso
Copy link
Contributor Author

Seems I have a toolchain issue with CI machines ... will need to coordinate with @akomakom

Ok ... Azure CI appears to lack support for toolchains.xml -- which the current approach to testing DumpUtility needs. I need to figure out a different approach.

I changed the approach to avoid dependence on toolchains.xml. The "extra" test execution for DumpUtilityTest now runs under the JVM running the Maven task. If the current JVM is less than 17, the extra test execution is suppressed; if 17 or greater, DumpUtilityTest is run with the proper --add-opens set.

@cljohnso
Updates to DumpUtility
c62a141 
This commit updates DumpUtility to:

* correct recognition of writable, BIG_ENDIAN, heap-resident IntBuffer
* make adjustments in support of Java 17+
* add usage comments
* add tests

For LongBuffer and IntBuffer, this update adds buffer description lines
for the Long/IntBuffer.
@cljohnso
Merge commit 'eb234476028d24678dc69990d7a33a507f680ef5' into correctD…
6d8e906 
…umpUtility
@cljohnso
Ensure running DumpUtilityTest under Java 17
6508ea9
@devlg75 devlg75 merged commit c2a1996 into Terracotta-OSS:master Oct 3, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlg75 devlg75 devlg75 approved these changes

@prasantakumar82 prasantakumar82 prasantakumar82 approved these changes

@chrisdennis chrisdennis Awaiting requested review from chrisdennis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cljohnso @devlg75 @prasantakumar82