Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Support booking button doesn't work when sign_up_link is an empty string #253

Open
jdudley1123 opened this issue Apr 8, 2020 · 0 comments
Open

Support booking button doesn't work when sign_up_link is an empty string #253

jdudley1123 opened this issue Apr 8, 2020 · 0 comments
Assignees
@jdudley1123
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@jdudley1123
Copy link
Member

jdudley1123 commented Apr 8, 2020 •
edited
Loading

If the sign_up_link field is an empty string (rather than a null string) then the check fails and the view treats the empty string as a link.

fusebox-insights/app/views/offers/show.html.erb

Line 26 in 6a6b9ba

<% link = @offer.sign_up_link || project_offer_book_path(@project, @offer) %>

@jdudley1123 jdudley1123 added the bug Something isn't working label Apr 8, 2020
@jdudley1123 jdudley1123 self-assigned this Apr 8, 2020
jdudley1123 added a commit that referenced this issue Apr 8, 2020
@jdudley1123
Fixed bug with blank string links
947e165 
Addresses #253

Switched from `.nil?` to `.blank?` to catch empty strings as well as null values.
@jdudley1123 jdudley1123 mentioned this issue Apr 8, 2020
Merged
@suninthesky suninthesky added the wontfix This will not be worked on label May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jdudley1123 jdudley1123

Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@suninthesky @jdudley1123