Fixed bug with blank string links

Addresses #253 Switched from `.nil?` to `.blank?` to catch empty strings as well as null values.
TechforgoodCAST · Apr 8, 2020 · 947e165 · 947e165
1 parent 124a5db
commit 947e165
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/views/offers/show.html.erb b/app/views/offers/show.html.erb
@@ -23,8 +23,8 @@
 
     <div class="mb-8">
       <% if current_user.is_project_member?(@project, %w[contributor mentor]) %>
-        <% link = @offer.sign_up_link || project_offer_book_path(@project, @offer) %>
-        <% link_id = @offer.sign_up_link.nil? ? 'email-support' : 'external-support' %>
+        <% link = @offer.sign_up_link.blank? ? project_offer_book_path(@project, @offer) : @offer.sign_up_link %>
+        <% link_id = @offer.sign_up_link.blank? ? 'email-support' : 'external-support' %>
         <%= link_to 'Book your place', link, class: 'btn bg-orange-500 hover:bg-orange-600 text-white ', id: link_id %>
       <% end %>
     </div>