Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for valid hibernate environment variables #817

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gmemstr
Copy link

@gmemstr gmemstr commented Jul 6, 2024

*nix systems can't have periods in their environment variable names, so we instead look for HIBERNATE prefixes, then lowercase and translate underscores to periods. This will allow for better compatibility with *nix systems when configuring likely sensitive hibernate values.

*nix systems can't have periods in their environment variable names, so we instead look for `HIBERNATE` prefixes, then lowercase and translate underscores to periods. This will allow for better compatibility with *nix systems when configuring likely sensitive hibernate values.
Copy link
Member

@FireMasterK FireMasterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would this work for configuration properties that have a _ such as hibernate.connection.handling_mode for example?

@gmemstr
Copy link
Author

gmemstr commented Jul 11, 2024

@FireMasterK Given that sort of variable isn't sensitive, I don't image many people would use an environment variable to set it. However, we could swap out a single underscore for a double underscore in the env variable names.

@FireMasterK
Copy link
Member

@FireMasterK Given that sort of variable isn't sensitive, I don't image many people would use an environment variable to set it. However, we could swap out a single underscore for a double underscore in the env variable names.

Yes I think that would be a reasonable workaround!

@gmemstr gmemstr requested a review from FireMasterK July 12, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants