Fix #215: Handle non-contiguous numbering in rustworkx backend
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackend This commit resolves a bug, as tested in the new test case `test_pauli_non_contiguous`, which previously passed with the `networkx` backend but failed with the `rustworkx` backend. The method `BaseGraphState.neighbors` now returns an iteration over (Graphix) node indices, rather than `rustworkx` vertex indices. These indices are then passed to `BaseGraphState.subgraph` in `BaseGraphState.local_complement`. `BaseGraphState.subgraph` expects node indices, as it converts them back to `rustworkx` vertex indices.
EarlMilktea
requested changes
Oct 17, 2024
Co-authored-by: S.S. <[email protected]>
Suggested by EarlMilktea: TeamGraphix#225 (comment)
EarlMilktea
approved these changes
Oct 17, 2024
shinich1
approved these changes
Oct 18, 2024
|
I merged |
|
Thanks. Everything is green: may I merge? |
|
Merged! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves a bug, as tested in the new test case
test_pauli_non_contiguous, which previously passed with thenetworkxbackend but failed with therustworkxbackend.The method
BaseGraphState.neighborsnow returns an iteration over (Graphix) node indices, rather thanrustworkxvertex indices.These indices are then passed to
BaseGraphState.subgraphinBaseGraphState.local_complement.BaseGraphState.subgraphexpects node indices, as it converts them back torustworkxvertex indices.