Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix fluid dupe? #610

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

ferriarnus
Copy link
Member

Description

There are a few bug reports related to fluid duping. This here is one of the only code paths I think something could go wrong. If nothing else this should simplify the code. I'll keep it a draft until we can verify why/how it happens.

Closes #503 #519 #595

Todo

  • Things that are yet to be completed for this PR to no longer be a draft.

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656
Copy link
Member

Rover656 commented Feb 7, 2024

I'll try to take a look at this PR tomorrow or Friday :)

@Rover656
Copy link
Member

I was unable to even reproduce a dupe bug on my side, but i think its reasonable to move to using the fluidutil :)

@ferriarnus ferriarnus marked this pull request as ready for review February 12, 2024 21:18
@ferriarnus ferriarnus merged commit 43e4ddb into Team-EnderIO:dev/1.20.1 Feb 12, 2024
4 checks passed
@ferriarnus ferriarnus deleted the fluidtank-changes branch February 12, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fluid Tanks Evilcraft condensed blood dupe
2 participants