Check for dimension in FireCraftingHandler fallback method

[Techjar]

Description

The fallback method for when doFireTick is disabled doesn't check which dimension the tracked fire belongs to, and thus will end up ignoring fires in dimensions other than the overworld, as the blocks obviously won't be found in the wrong dimension and it simply removes the tracker entries. It also breaks with doFireTick enabled when Aether is installed, due to Aether using a wrapped gamerules object to return false for doFireTick in its dimension only.

The fix is very simple, just skip over any non-matching dimension entries when iterating. I tested locally with Aether installed and confirmed it works.

This shouldn't be a breaking change.

Closes #603

Checklist:

• My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
• I have performed a self-review of my own code.
• I have commented my code in areas it may be challenging to understand.
• I have made corresponding changes to the documentation.
• My changes are ready for review from a contributor.

[ferriarnus]

Yeah this makes sense, seems we missed that code path. It looks fine to merge IMO, or do we wait for 1.20.2 @Rover656 ?

[Rover656]

Happy to merge into 20.1 :) I kinda want to squash a few of the bugs left over if I can anyway :p

[Rover656]

Thanks a lot for this Techjar!