Check for dimension in FireCraftingHandler fallback method #606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fallback method for when doFireTick is disabled doesn't check which dimension the tracked fire belongs to, and thus will end up ignoring fires in dimensions other than the overworld, as the blocks obviously won't be found in the wrong dimension and it simply removes the tracker entries. It also breaks with doFireTick enabled when Aether is installed, due to Aether using a wrapped gamerules object to return false for doFireTick in its dimension only.
The fix is very simple, just skip over any non-matching dimension entries when iterating. I tested locally with Aether installed and confirmed it works.
This shouldn't be a breaking change.
Closes #603
Checklist: