Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Conduit to the commonly used forge:relocation_not_supported tag #584

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

justliliandev
Copy link
Contributor

Description

The conduit block should've been in this tag from the beginning, I thought I did that, but I guess I forgot

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you!

@Rover656 Rover656 merged commit 91b6719 into dev/1.20.1 Jan 9, 2024
4 checks passed
@Rover656 Rover656 deleted the fix/conduit_relocation branch February 10, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants