Fix/energylobeingnotpresentandmeplacecrash

src/conduits/java/com/enderio/conduits/common/blockentity/ConduitBundle.java

@@ -19,8 +19,11 @@
 import net.minecraft.world.level.block.state.BlockState;
 import net.minecraftforge.common.util.INBTSerializable;
 import net.minecraftforge.fml.LogicalSide;
+import net.minecraftforge.fml.ModList;
 import net.minecraftforge.fml.loading.FMLLoader;
 import net.minecraftforge.fml.util.thread.EffectiveSide;
+import net.minecraftforge.forgespi.language.IModInfo;
+import org.apache.maven.artifact.versioning.DefaultArtifactVersion;
 import org.jetbrains.annotations.Nullable;
 
 import java.util.ArrayList;
@@ -49,6 +52,13 @@ public final class ConduitBundle implements INBTSerializable<CompoundTag> {
 
     private int dataVersion = Integer.MIN_VALUE;
 
+    private static final boolean IS_NEO_ENV_AFTER_ON_LOAD_CHANGE;
+
+    static {
+
+        IModInfo forge = ModList.get().getModFileById("forge").getMods().get(0);
+        IS_NEO_ENV_AFTER_ON_LOAD_CHANGE = forge.getDisplayName().equals("NeoForge") && forge.getVersion().compareTo(new DefaultArtifactVersion("47.1.77")) >= 0;
+    }
     public ConduitBundle(Runnable scheduleSync, BlockPos pos) {
         this.scheduleSync = scheduleSync;
         for (Direction value : Direction.values()) {
@@ -113,7 +123,11 @@ public RightClickAction addType(Level level, IConduitType<?> type, Player player
         } else {
             types.add(type);
             nodes.put(type, node);
-            node.getExtendedConduitData().onCreated(type, level, pos, player);
+            if (types.size() != 1 || !IS_NEO_ENV_AFTER_ON_LOAD_CHANGE) {
+                //NeoForge contains a patch that calls onLoad after the conduit has been placed if it's the first one, so onCreated would be called twice. it's easier to detect here
+                //TODO, remove neocheck and just keep the size check with an explaining comment on why we have a types.size check at all
+                node.getExtendedConduitData().onCreated(type, level, pos, player);
+            }
         }
 
         scheduleSync.run();

src/conduits/java/com/enderio/conduits/common/integrations/ae2/AE2ConduitType.java

@@ -55,7 +55,7 @@ public AE2InWorldConduitNodeHost createExtendedConduitData(Level level, BlockPos
     @Override
     public <K> Optional<LazyOptional<K>> proxyCapability(Capability<K> cap, AE2InWorldConduitNodeHost extendedConduitData, Level level, BlockPos pos, @Nullable Direction direction, Optional<NodeIdentifier.IOState> state) {
         if (getCapability() == cap) {
-            return Optional.of(extendedConduitData.selfCap.cast());
+            return Optional.of(extendedConduitData.getSelfCap().cast());
         }
         return Optional.empty();
     }

src/conduits/java/com/enderio/conduits/common/integrations/ae2/AE2InWorldConduitNodeHost.java

@@ -24,7 +24,7 @@ public class AE2InWorldConduitNodeHost implements IInWorldGridNodeHost, IExtende
     @Nullable
     private IManagedGridNode mainNode = null;
 
-    final LazyOptional<AE2InWorldConduitNodeHost> selfCap = LazyOptional.of(() -> this);
+    private LazyOptional<AE2InWorldConduitNodeHost> selfCap = LazyOptional.of(() -> this);
 
     public AE2InWorldConduitNodeHost(AE2ConduitType type) {
         this.type = type;
@@ -53,6 +53,13 @@ public IGridNode getGridNode(Direction dir) {
         return mainNode.getNode();
     }
 
+    public LazyOptional<AE2InWorldConduitNodeHost> getSelfCap() {
+        if (!selfCap.isPresent()) {
+            selfCap = LazyOptional.of(() -> this);
+        }
+        return selfCap;
+    }
+
     @Override
     public AECableType getCableConnectionType(Direction dir) {
         if (type.isDense()) {

src/conduits/java/com/enderio/conduits/common/types/EnergyConduitTicker.java

@@ -31,7 +31,7 @@ public void tickGraph(IConduitType<?> type, List<NodeIdentifier<?>> loadedNodes,
         super.tickGraph(type, loadedNodes, level, graph, isRedstoneActive);
         for (NodeIdentifier<?> node : loadedNodes) {
             EnergyExtendedData energyExtendedData = node.getExtendedConduitData().castTo(EnergyExtendedData.class);
-            IEnergyStorage energy = energyExtendedData.selfCap
+            IEnergyStorage energy = energyExtendedData.getSelfCap()
                 .resolve()
                 .orElseThrow();
             if (energy.getEnergyStored() == 0) {

src/conduits/java/com/enderio/conduits/common/types/EnergyConduitType.java

@@ -46,7 +46,7 @@ public <K> Optional<LazyOptional<K>> proxyCapability(Capability<K> cap, EnergyEx
         if (ForgeCapabilities.ENERGY == cap
             && state.map(NodeIdentifier.IOState::isExtract).orElse(true)
             && (direction == null || !level.getBlockState(pos.relative(direction)).is(ConduitTags.Blocks.ENERGY_CABLE))) {
-                return Optional.of(extendedConduitData.selfCap.cast());
+                return Optional.of(extendedConduitData.getSelfCap().cast());
 
         }
         return Optional.empty();

src/conduits/java/com/enderio/conduits/common/types/EnergyExtendedData.java

@@ -23,7 +23,7 @@ public class EnergyExtendedData implements IExtendedConduitData<EnergyExtendedDa
     private int capacity = 500;
     private int stored = 0;
 
-    final LazyOptional<IEnergyStorage> selfCap = LazyOptional.of( () -> new ConduitEnergyStorage(this));
+    private LazyOptional<IEnergyStorage> selfCap = LazyOptional.of( () -> new EnergyExtendedData.ConduitEnergyStorage(this));
 
 
     @Override
@@ -82,6 +82,13 @@ public EnergySidedData compute(Direction direction) {
         return energySidedData.computeIfAbsent(direction, dir -> new EnergySidedData());
     }
 
+    LazyOptional<IEnergyStorage> getSelfCap() {
+        if (!selfCap.isPresent()) {
+            selfCap = LazyOptional.of(() -> new EnergyExtendedData.ConduitEnergyStorage(this));
+        }
+        return selfCap;
+    }
+
     public static class EnergySidedData {
         public int rotatingIndex = 0;