Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XP fluid conversions #377

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Fix XP fluid conversions #377

merged 2 commits into from
Jul 30, 2023

Conversation

Rover656
Copy link
Member

Description

Fixes forge:experience fluid conversion to XP Juice. Could also convert to whatever xp fluid is already in the tank, but it makes very little difference tbh.

Fixes #350 and #310

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656
Convert to our own XP fluid always.
85ddd02 
Could also convert to whatever xp fluid is already in the tank, but it makes very little difference tbh.
@Rover656 Rover656 added Type-Bug There is a problem. MC-1.20.1 labels Jul 28, 2023
@Rover656 Rover656 linked an issue Jul 28, 2023 that may be closed by this pull request
[BUG] <Soul Binder Server Syncing issue> #310
Closed
1 task
@Rover656 Rover656 changed the title Convert to our own XP fluid always. Fix XP fluid conversions Jul 29, 2023
@Rover656 Rover656 merged commit 0b7827d into dev/1.20.1 Jul 30, 2023
1 check passed
@Rover656 Rover656 deleted the fix/soul-binder-convert branch August 11, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferriarnus ferriarnus ferriarnus left review comments

@justliliandev justliliandev Awaiting requested review from justliliandev

Assignees
No one assigned
Labels
MC-1.20.1 Type-Bug There is a problem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Soulbinder Broken [BUG] <Soul Binder Server Syncing issue>
2 participants
@Rover656 @ferriarnus