Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Drain #373

Merged
merged 16 commits into from
Aug 19, 2023
Merged

Add Drain #373

merged 16 commits into from
Aug 19, 2023

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Jul 28, 2023 •
edited
Loading

Description

Add Drain

Closes #137

Todo

  • Models
  • Gui
  • Range
  • Per fluid energy cost?

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@ferriarnus ferriarnus marked this pull request as ready for review August 17, 2023 16:35
@Rover656
Copy link
Member

Datagen breaking due to: enderio:block/drain_front texture being missing

Rover656
Rover656 requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting range = 0 crashes the game and the datagen needs fixing please ;)

@Rover656 Rover656 self-requested a review August 19, 2023 16:36
Rover656
Rover656 approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Ferri!

@Rover656 Rover656 added Type-Enhancement New feature or enhancement to existing feature. MC-1.20.1 labels Aug 19, 2023
@Rover656 Rover656 merged commit 61448c8 into Team-EnderIO:dev/1.20.1 Aug 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rover656 Rover656 Rover656 approved these changes

Assignees
No one assigned
Labels
MC-1.20.1 Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pump
2 participants
@ferriarnus @Rover656