Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace missed NBTKeys + Add paint to paint recipe #320

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Jul 19, 2023

Description

Some NBTKeys were missed causing painted blocks to not have the correct nbt.
Add a new recipe to repaint painted blocks.

Closes #304

Todo

  • New recipe or add the painted blocks to the wood tag?

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; just waiting on hearing back about the TODO from you in Discord, then we're good to merge!

@Rover656 Rover656 added Type-Bug There is a problem. Type-Enhancement New feature or enhancement to existing feature. MC-1.20.1 P-1-Medium Medium priority. Potentially deleting items or breaking functionality. labels Jul 20, 2023
@Rover656 Rover656 merged commit bc78bc5 into Team-EnderIO:dev/1.20.1 Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MC-1.20.1 P-1-Medium Medium priority. Potentially deleting items or breaking functionality. Type-Bug There is a problem. Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] breaking a painted block removes texture
2 participants