Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ifdef open64/lseek64 #10

Merged
merged 1 commit into from
Sep 22, 2023
Merged

ifdef open64/lseek64 #10

merged 1 commit into from
Sep 22, 2023

Conversation

krenzland
Copy link
Contributor

No description provided.

davschneller
davschneller reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@davschneller davschneller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the arguments really identical? Then why don't we make only the function name ifdef-guarded, but keep the arguments as they are?

@krenzland
Copy link
Contributor Author

I think so. The only difference is the offset length AFAIK. I can move the template to the function name, but that isn't really much better IMO as this makes it harder to edit it

davschneller
davschneller approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@davschneller davschneller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then I'll approve it for the time being.

@davschneller davschneller merged commit fcc666c into master Sep 22, 2023
4 checks passed
@davschneller davschneller deleted the macos branch September 22, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davschneller davschneller davschneller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krenzland @davschneller