Fixed hanging bash commands from agent in os-task #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the agent puts out a command like
'while true; do ls /root; sleep 1; done'
it will loop while also putting out an output (meaning the socket
doesn't timeout) so I've added a 30s cutoff. Without this it eventually
fails but counts as an incomplete task rather than just a fail so it
stops any of the overall stats working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the agent puts out a command like
'while true; do ls /root; sleep 1; done'
it will loop while also putting out an output (meaning the socket doesn't timeout) so I've added a 30s cutoff. Without this it eventually fails but counts as an incomplete task rather than just a fail so it stops any of the overall stats working. With this fix the model will receive any output from the terminal up to this time cutoff.
There are other ways to address this problem (such as raising/catching an error instead of allowing the conversation to continue), please let me know if you think a different approach is better.