Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] task get api TargetArea 연동 #175

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

wrryu09
Copy link
Member

@wrryu09 wrryu09 commented Jul 17, 2024

작업 내용 🧑‍💻

  • TargetArea 쪽 더미데이터 빼고 api 연결했습니다
  • date 전달 위해서 유틸에 LocalDate 포맷으로 변경하는 함수 하나 더 만들었습니다.

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

관련 이슈

close #173

스크린샷 (선택)

image

@wrryu09 wrryu09 self-assigned this Jul 17, 2024
@wrryu09 wrryu09 linked an issue Jul 17, 2024 that may be closed by this pull request
Copy link
Contributor

@Kjiw0n Kjiw0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 받아오는 것 확인했습니다! 수고해써영

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너 무 조아요

Copy link
Member

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

먼저 react-query 예시를 잘 만들어주셔서 뒤에 api를 연결하는 사람들이 잘 사용할 수 있을 거 같아요 수고하셨습니다!! 👍


const { handleSelectedTarget, selectedTarget, selectedDate } = props;
const targetDate = formatDatetoLocalDate(selectedDate);
const { isFetched, data } = useGetTasks({ targetDate });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error처리도 함께 하면 좋을 것 같은데 현재 에러이면 콘솔에 출력하는 거 말고는 따로 에러 처리 방법이 없어서 에러 처리를 어떤 식으로 할지 함께 이야기해보고 통일 시키는 것도 좋겠네요! 현재 상황에서는 이게 최선인 것 같습니다 !!

@wrryu09 wrryu09 merged commit f002b58 into develop Jul 17, 2024
2 checks passed
@wrryu09 wrryu09 deleted the feat/#173/task-get-targetarea branch July 17, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] task get api TargetArea 연동
3 participants