-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/WP-420: Search placeholder does not update on navigating to directories #989
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #989 +/- ##
=======================================
Coverage 73.09% 73.09%
=======================================
Files 531 531
Lines 33167 33167
Branches 2917 2916 -1
=======================================
Hits 24244 24244
Misses 8729 8729
Partials 194 194
Flags with carried forward coverage won't be shown. Click here to find out more.
|
client/src/components/DataFiles/DataFilesListing/DataFilesListing.jsx
Outdated
Show resolved
Hide resolved
…ing.jsx Co-authored-by: Sal Tijerina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More information on why this line change is done for Search placeholders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
On CEP Shared Workspaces → any workspace title still says "Search Root"
Related
Changes
UI
All Shared Workspaces
Navigating into a Shared Workspace Before
Navigating into a Shared Workspace After