Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/WP-420: Search placeholder does not update on navigating to directories #989

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jalowe13
Copy link
Collaborator

@jalowe13 jalowe13 commented Oct 22, 2024

Overview

On CEP Shared Workspaces → any workspace title still says "Search Root"

Related

Changes

  • Changed the logic that shows "Search Root" to the current working directory folder name instead of Root. The only time that this would occur is on the first project directory navigation. The rest of the navigations into additional sub folders seems correct

UI

All Shared Workspaces

image

Navigating into a Shared Workspace Before

image

Navigating into a Shared Workspace After

image

@jalowe13 jalowe13 marked this pull request as draft October 22, 2024 20:03
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.09%. Comparing base (72126c4) to head (4223238).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #989   +/-   ##
=======================================
  Coverage   73.09%   73.09%           
=======================================
  Files         531      531           
  Lines       33167    33167           
  Branches     2917     2916    -1     
=======================================
  Hits        24244    24244           
  Misses       8729     8729           
  Partials      194      194           
Flag Coverage Δ
javascript 76.12% <100.00%> (ø)
unittests 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ts/DataFiles/DataFilesListing/DataFilesListing.jsx 95.13% <100.00%> (ø)

@jalowe13 jalowe13 marked this pull request as ready for review October 22, 2024 20:48
Copy link
Collaborator Author

@jalowe13 jalowe13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More information on why this line change is done for Search placeholders

Copy link
Member

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants