Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WP-78: V3 Shared Workspaces Tests #987

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

jalowe13
Copy link
Collaborator

@jalowe13 jalowe13 commented Oct 18, 2024

Overview

Updating the shared workspace fixtures and tests to V3

Current work in progress until amount of V3 tests made is sufficient.

Tests converted 4/10

Related

Changes

  • Formatting of previous tests changes in style with prettier
  • Added mocks for the tapis client return values to implement behavior based testing on creating a new Shared Workspace Project.
  • Created assertions to test for a new Shared Workspace Project being created. Tested assertions against mocks of high level interpretations of functions used in shared_workspace_operations.py.
  • The test_project_init is fully implemented to my knowledge. Those fixtures that are inside the function can be used in other tests below the initial.

Testing

  1. Run the core portal django container
    docker exec -it core_portal_django bash
  2. Running individual test
    pytest portal/apps/projects/unit_test.py
  3. Running all backend tests
    pytest -ra

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.10%. Comparing base (72126c4) to head (d9636df).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   73.09%   73.10%           
=======================================
  Files         531      531           
  Lines       33167    33167           
  Branches     2917     2917           
=======================================
+ Hits        24244    24246    +2     
+ Misses       8729     8728    -1     
+ Partials      194      193    -1     
Flag Coverage Δ
javascript 76.12% <ø> (ø)
unittests 60.15% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@jalowe13 jalowe13 marked this pull request as draft October 18, 2024 21:47
@jalowe13 jalowe13 changed the title [WIP] Task/WP-78: V3 Shared Workspaces Tests Task/WP-78: V3 Shared Workspaces Tests Oct 18, 2024
@jalowe13
Copy link
Collaborator Author

jalowe13 commented Oct 18, 2024

Changed to a draft PR. Let me know if this is not sufficient and if a [WIP] header needs to go back on!

@jalowe13
Copy link
Collaborator Author

test_project_create close to completion. initial mock setup put into a generalized fixture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant