-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/WP-78: V3 Shared Workspaces Tests #987
Draft
jalowe13
wants to merge
20
commits into
main
Choose a base branch
from
task/WP-78--v3-shared-workspaces-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+440
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
=======================================
Coverage 73.09% 73.10%
=======================================
Files 531 531
Lines 33167 33167
Branches 2917 2917
=======================================
+ Hits 24244 24246 +2
+ Misses 8729 8728 -1
+ Partials 194 193 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
jalowe13
changed the title
[WIP] Task/WP-78: V3 Shared Workspaces Tests
Task/WP-78: V3 Shared Workspaces Tests
Oct 18, 2024
Changed to a draft PR. Let me know if this is not sufficient and if a [WIP] header needs to go back on! |
test_project_create close to completion. initial mock setup put into a generalized fixture |
… tests need the mock storage
…ub.com/TACC/Core-Portal into task/WP-78--v3-shared-workspaces-tests commit errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updating the shared workspace fixtures and tests to V3
Current work in progress until amount of V3 tests made is sufficient.
Tests converted 4/10
Related
Changes
Testing
docker exec -it core_portal_django bash
pytest portal/apps/projects/unit_test.py
pytest -ra