task/WMAQA-45 Shared Workspace Tests #23
Conversation
| test('Cleanup shared workspaces', async ({ page, baseURL }) => { | ||
| const {USERNAME: username, PASSWORD: password} = process.env; | ||
|
|
||
| const tenant = 'https://portals.tapis.io'; |
There was a problem hiding this comment.
I think this is ok for now, but we're going to need to parameterize this if we want to test portals on different tenants.
| @@ -29,7 +29,8 @@ | |||
| data = { | |||
| "PORTAL_DATAFILES_STORAGE_SYSTEMS": custom_portal_settings._PORTAL_DATAFILES_STORAGE_SYSTEMS or [], | |||
| "SYSTEM_MONITOR_DISPLAY_LIST": custom_portal_settings._SYSTEM_MONITOR_DISPLAY_LIST or [], | |||
| "NGINX_SERVER_NAME": os.getenv('NGINX_SERVER_NAME') | |||
| "NGINX_SERVER_NAME": os.getenv('NGINX_SERVER_NAME'), | |||
| "PORTAL_PROJECTS_SYSTEM_PREFIX": custom_portal_settings._PORTAL_PROJECTS_SYSTEM_PREFIX or '' | |||
There was a problem hiding this comment.
These or statements don't actually work for me if the key value is missing from the config file. I think you're looking for something like value = <value_if_true> if <expression> else <value_if_false>
There was a problem hiding this comment.
The or statements should work. Can you check what python version you have to make sure that isn't an issue?
shayanaijaz
requested review from
fnets,
SilversunKSauri,
edmondsgarrett and
jmartinez-tacc
| } | ||
| }) | ||
|
|
||
| async function getAccessToken(page, username, password, tenant) { |
There was a problem hiding this comment.
It looks like this will work, but I think a more secure way to do it would be to use this api:
That way, we're not transmitting passwords or anything. Normally, I'd say we wouldn't want to use the portal to test the portal, but I think in this case it makes sense.
|
|
||
| } | ||
|
|
||
| async function getSystems(page, tenant, projectPrefix, accessToken) { |
There was a problem hiding this comment.
Do we want to delete all the shared systems, or just the one we created in these tests? Is there an easy or free way to get that system id at system creation? I'll take a look to try and save you a headache.
There was a problem hiding this comment.
Oh, it looks like it's available in the Shared Workspaces view and in the URL.
Overview
Added tests for shared workspaces. Also added a teardown project that deals with deleting shared workspaces directly using tapis
Changes
Testing
Notes
In the shared workspace teardown there's a new function
page.evaluatebeing used when doing external http calls. More details about why this is needed and what it does can be found here