Hotfix/fix vite config and remove warning #275
+21
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes warning about default props for this component: "Support for defaultProps will be removed from function components in a future major release"
Added probably during conflict resolution
nathanfranklin
requested review from
taoteg,
rstijerina,
shayanaijaz and
sophia-massie
nathanfranklin
commented
Oct 25, 2024
| @@ -25,8 +25,25 @@ module.exports = { | |||
| collectCoverage: true, | |||
|
|
|||
| // An array of glob patterns indicating a set of files for which coverage information should be collected | |||
There was a problem hiding this comment.
if we don't say what to grab, it only shows coverage for files that are tested. so if we aren't testing a component then it doesn't show up in our coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR has some minor fixes:
PR Status:
Testing Steps: