feat: tup-700 core components node pkg use pkg #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem was forgetting to build core-components before packing.
Problem was… core-components not coded/tested for external usage. Fixes in TACC/tup-ui: TACC/tup-ui@cb73d54 TACC/tup-ui@836f372
5 tasks
sophia-massie
requested review from
sophia-massie
and removed request for
sophia-massie
This was referenced Oct 15, 2024
* Update config files * task/wg-76-project-listing-query (#265) * task/wg-76-project-listing-query * Address linting errors * - Combines DesignSafe and Hazmapper project get requests into one hook * - Linting * Add local version of QueryNavItem to illustrate issue * Use @tacc/core-components version 0.0.3-beta.0 * Fix prettier issues * Update package lock * Update package-lock.json again * hotfix: simplify imports in react app (#260) * Simplify imports in react app * Fix linting * Revert changes to core-wrappers * Add maping to jest * Fix linting * Fix pretty issues * Remove unused imports from mistake in conflict resolution * Update as core-components is now installed from package --------- Co-authored-by: sophia-massie <[email protected]>
wesleyboar
commented
Oct 18, 2024
There was a problem hiding this comment.
I tested. App runs without error. App looks like it is a WIP (not broken). I don't see any core-components to test. I trust @nathanfranklin's approval and changes since mine.
nathanfranklin
deleted the
feat/TUP-700-core-components-node-pkg--use-pkg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Replace
core-componentsandcore-wrapperswith upcoming @tacc/core-components.Tip
Joint effort of @wesleyboar and @nathanfranklin.
PR Status:
Related Jira tickets:
Summary of Changes:
core-componentsandcore-wrappers@tacc/core-components(test of local install)core-…to use@tacc/core-componentscore-componentsandcore-wrappersTesting Steps:
Archived
npm install --save ../../tacc-core-components-0.0.1.tgz1UI Photos:
…
Footnotes
You can get the package by following "Testing" "0." in https://github.com/TACC/tup-ui/pull/464. ↩