Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-295: improve error message when duplicate syncing project #255

Conversation

nathanfranklin
Copy link
Collaborator

Overview:

This PR improves the error message when trying to create a duplicate syncing project.

This matches the error message handling we already have in the react client.

PR Status:

  • Ready.

Related Jira tickets:

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be updated to main and have a one line fix to allow for hazmapper.local:4200 option to still work when running geoapi locally. Nathan is already working on that (can be a follow on if needed). Otherwise, LGTM

@nathanfranklin nathanfranklin merged commit 785bb9f into main Sep 17, 2024
5 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-295-improve-error-message-handling-on-project-creation branch September 17, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants