Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-264: Hazmapper suffix fix #227

Merged
merged 7 commits into from
Apr 3, 2024
Merged

Conversation

tjgrafft
Copy link
Contributor

@tjgrafft tjgrafft commented Mar 28, 2024

Overview:

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Before this PR, the .hazmapper extenion was being pushed out of the input box every time the "File name required" text was rendered from the Yup validation.
  • Now the hazmapper extension will stay inside the input box when the validation text appears, making the UI look cleaner.

Testing Steps:

  1. Run with local geoapi backend (master branch is fine)
  2. Open the "Create Map" modal
  3. Verify that the ".hazmapper" extension is present in the Custom File Name field
  4. Start typing a file name in that field, then delete the text and click out/unfocus from the Custom File Name field so that the "File name is required" text pops up.
  5. When it does, verify that the ".hazmapper" extension text is still inside the input box
  6. Compare with the screenshots below

UI Photos:

Screenshot 2024-03-28 at 3 24 41 PM Screenshot 2024-03-28 at 3 25 20 PM

Notes:

@tjgrafft tjgrafft marked this pull request as ready for review March 28, 2024 21:11
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM 👍

Copy link
Contributor

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose a simpler solution.

@tjgrafft tjgrafft requested a review from wesleyboar April 3, 2024 13:53
@tjgrafft tjgrafft merged commit a2ebd66 into master Apr 3, 2024
5 checks passed
@tjgrafft tjgrafft deleted the task/WG-264-hazmapper-suffix branch April 3, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants