Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-261: mock v3 project designsafe #220

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

tjgrafft
Copy link
Contributor

@tjgrafft tjgrafft commented Mar 4, 2024

Overview:

Jake provided a example of the new DS v3 project response. Because there is no v3 designsafe portal, yet, we needed to mock a response so we could get a listing of projects (each is its own system) from a UI standpoint when creating a new map.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Created a projectv3.fixture.ts file that represents a project (project system) response that will come from the /api/projects endpoint once the v3 DS portal is up and running.
  • Added code to use the mock fixture so that the project would show under 'My Projects' in the dropdown when creating a new map and selecting a system to save the map.

Testing Steps:

  1. For the backend, run local on the feature/tapisv3 branch
  2. Run with angular hazmapper
  3. Click the Create a Map button so the modal appears
  4. Under the file browser, click the dropdown menu and confirm that both My Data and the example mock v3 project system fixture is present (this will be under My Projects as the name TEST: Hazmapper/TapisV3 project)
  5. Compare with screenshot below and make sure file listings are showing too

UI Photos:

Screenshot 2024-03-04 at 2 47 46 PM

Notes:

Once v3 DS portal is up and running we will make a request to DS projects endpoint directly and remove the mock fixture.

@tjgrafft tjgrafft changed the base branch from master to feature/tapisv3 March 4, 2024 20:05
@tjgrafft tjgrafft changed the title Task/wg 261 mock v3 project designsafe task/WG-261: mock v3 project designsafe Mar 4, 2024
@nathanfranklin nathanfranklin self-requested a review March 19, 2024 15:12
@nathanfranklin nathanfranklin marked this pull request as ready for review March 19, 2024 15:12
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tjgrafft tjgrafft merged commit 6a5c507 into feature/tapisv3 Mar 25, 2024
5 checks passed
@tjgrafft tjgrafft deleted the task/WG-261-mock-v3-project-designsafe branch March 25, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants