Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/DES-2217 - bump version ng12 #129

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

task/DES-2217 - bump version ng12 #129

wants to merge 11 commits into from

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Mar 29, 2023 •
edited
Loading

Overview:

This uses a newer version of ng-tapis which uses angular 12 (see TACC-Cloud/ng-tapis#6)

TODO:

  • different buttons down't work: make-public, delete etc
  • selecting project on main screen doesn't work at moment (routes not working, right? ) (you can enter route directly to test a certain map).
  • add missing modules for unit testing

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Testing Steps:

  1. Test everything

@nathanfranklin nathanfranklin mentioned this pull request Mar 29, 2023
Merged
@nathanfranklin nathanfranklin changed the title Bump version ng12 task/DES-2217 - bump version ng12 Mar 29, 2023
@nathanfranklin nathanfranklin marked this pull request as draft May 10, 2023 20:15
@nathanfranklin nathanfranklin removed the request for review from duckonomy May 10, 2023 20:15
taoteg
taoteg approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did not run locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoteg taoteg taoteg approved these changes

@sophia-massie sophia-massie Awaiting requested review from sophia-massie

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanfranklin @taoteg