Feature: Make User Cloud tab hideable #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshalot
reviewed
Mar 7, 2023
Comment on lines
11
to
12
| if settings.ENABLE_RESEARCH_ENVIRONMENTS: | ||
| default_tabs.remove('Cloud') |
There was a problem hiding this comment.
I don't think this logic is correct - having research environments enabled does not necessarily imply that we won't have Cloud integrations. This looks more like a completely new setting.
Maybe in the future we should align the CloudInformation model with the CloudIdentity model?
kshalot
requested changes
Mar 7, 2023
rafalkosla101
force-pushed
the
feature/remove_cloud_tab_when_using_hdn_extension
branch
from
89585f1
to
a9cee10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using HealthDataNexus instance of Physionet it seems that the "Cloud" tab inside of account page is redundant. We are using out internal flow to integrate with Google Cloud Services and having such page under account page may be misleading for the user. This PR should not be merged until we introduce appropriate settings that were already mentioned in Karol's PR.
The PR itself removes one of the tabs when the alternative flow of getting Google identity is enabled.