Unskip MetaMask add/switch network tests #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #361 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
duckception
force-pushed
the
duckception/unskip-metamask-network-tests
branch
from
b886b8d
to
04b1336
Compare
drptbl
reviewed
Aug 17, 2023
Comment on lines
+7
to
+10
| RUN apt update && apt install -y nginx | ||
|
|
||
| COPY nginx.conf /etc/nginx/sites-available/default | ||
|
|
There was a problem hiding this comment.
I'm not sure if this is good place to add this piece. The issue is that people use this Dockerfile as a reference to run their setup and nginx in most cases is redundant there and is very specific to our use case.
Nevertheless, sooner or later there may be more cases with specific things to our setup, so maybe it's not a huge issue at all. We can provide proper examples in synpress-examples repo.
drptbl
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating Nginx allows us to redirect
http://127.0.0.1:8545calls tohttp://foundry:8545andhttp://127.0.0.1:8546calls tohttp://foundry-metamask-test-dapp:8546. With this, we don't have to worry about conditionally handling RPC URLs or RPC calls to a local node from the MetaMask Test Dap when running tests in docker.