Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent behavior in initialSetup when using another extension #816

Closed
wants to merge 26 commits into from

Conversation

matt-user
Copy link

Motivation and context

When using another extension in testing the other extension was getting assigned to the metamask window and breaking the tests. This adds an additional check such that the metamask window will get set correctly

Does it fix any issue?

#798

Quality checklist

  • [ x] I have performed a self-review of my code.
  • [ x] If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

@r3kt-eth
Copy link
Contributor

r3kt-eth commented Aug 2, 2023

Fixed in #821

thanks for raising this up!

@r3kt-eth r3kt-eth closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants